{{ message }}
Repository navigation
More items
Fix sidebarbutton CSS styling - #332
Closed
sepehr-rs wants to merge 2 commits into
Closed
sepehr-rs wants to merge 2 commits into
sepehr-rs wants to merge 2 commits into
Conversation
Copy link
Copy Markdown
Documentation build overview19 files changed
|
Co-authored-by: Stan Ulbrych <stan@python.org>
Copy link
Copy Markdown
Member
|
Building the documentation with this change, I'm not sure we need to change anything here? (I wanted to attach screenshots, but something seems to be wrong and GitHub isn't displaying them.) and are mirrored characters in Unicode so when the text runs right-to-left, the browser automatically switches for . Looking at the current documentation, this looks correct for both LTR and RTL. With this PR, it's flipped twice and is wrong. Maybe this is browser specific, however, in Firefox it is correct. |
![[image]](https://private-user-images.githubusercontent.com/176217911/657144768-4b8b4df8-2200-4232-bb59-bf7715618179.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3OTI0OTYyMDAsIm5iZiI6MTc5MjQ5NTkwMCwicGF0aCI6Ii8xNzYyMTc5MTEvNjU3MTQ0NzY4LTRiOGI0ZGY4LTIyMDAtNDIzMi1iYjU5LWJmNzcxNTYxODE3OS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjYxMDIwJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI2MTAyMFQxMTMxNDBaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT02MzU3YzQxOGNjMTY0Nzk0YmZmZTFiNmI5NjU3NTJhMTM2ODFhMjI4YWU0NGM3NDU4NGQzNTgyNmViMTY0Y2QyJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZyZXNwb25zZS1jb250ZW50LXR5cGU9aW1hZ2UlMkZwbmcifQ.Ko_gtC4CSlez9VM40oB4fw2IdwWxsGhvs-QDUuLiKnw){kind=link}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the sidebar button being reversed, as mentioned in #331. We can remove this once RTL support is added to Sphinx, since the sidebar button is originally managed by Sphinx. Please let me know if any changes are needed!