[ Web Proxy ]
URL:
Viewing: https://github-redirect.dependabot.com/shelljs/shelljs/pull/925 [Back]  [Original]

test(touch): add coverage for -d option by nfischer Pull Request #925 shelljs/shelljs GitHub
Skip to content

Navigation Menu

Sign in
Search/
Sign up

test(touch): add coverage for -d option - #925

Merged
nfischer merged 1 commit into
masterfrom
test-touch-date
Jan 4, 2019
Merged

test(touch): add coverage for -d option#925
nfischer merged 1 commit into
masterfrom
test-touch-date

Conversation

@nfischer [@nfischer]

Copy link
Copy Markdown
Member

No change to production logic.

We never had coverage for touch({'-d': ...}), so this adds test
coverage. This also updates documentation to clarify the parameter
should be an instance of the Date type.

Test: handles date argument case

[Go]
No change to production logic.

We never had coverage for `touch({'-d': ...})`, so this adds test
coverage. This also updates documentation to clarify the parameter
should be an instance of the `Date` type.

Test: `handles date argument` case

Copy link
Copy Markdown

Codecov Report

Merging #925 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph [Impacted file tree graph]

@@           Coverage Diff           @@
##           master     #925   +/-   ##
=======================================
  Coverage   97.26%   97.26%           
=======================================
  Files          34       34           
  Lines        1281     1281           
=======================================
  Hits         1246     1246           
  Misses         35       35
Impacted Files Coverage
src/touch.js 100% <> ()

Continue to review full report at Codecov.

Legend - Click here to learn more
= absolute <relative> (impact), = not affected, ? = missing data
Powered by Codecov. Last update 355287e...e1fb25a. Read the comment docs.

[Go]

nfischer commented Jan 4, 2019

Copy link
Copy Markdown
Member Author

This was covered by some cp.js tests, but it's probably clearer to put a test in touch.js anyway.

[Go]
nfischer merged commit 5371e16 into master Jan 4, 2019
nfischer deleted the test-touch-date branch January 4, 2019 10:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Footer

© 2026 GitHub, Inc.

Web Proxy Viewer  |  New URL  |  Original Page