{{ message }}
fix(bin/options): correct check for color support (options.color) - #1555
Merged
michael-ciniawsky merged 2 commits intoOct 30, 2018
Merged
michael-ciniawsky merged 2 commits into
michael-ciniawsky merged 2 commits into
Conversation
jayjun
requested review from
alexander-akait and
michael-ciniawsky
as code owners
October 30, 2018 11:43
[@alexander-akait]
alexander-akait
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Looks good, due no tests please add comment in code why we use this with link on issue/PR
options.color)
Oct 30, 2018
[@michael-ciniawsky]
michael-ciniawsky
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
@jayjun Thx
Copy link
Copy Markdown
Codecov Report
@@ Coverage Diff @@
## master #1555 +/- ##
=======================================
Coverage 74.02% 74.02%
=======================================
Files 10 10
Lines 670 670
=======================================
Hits 496 496
Misses 174 174
Continue to review full report at Codecov.
|
This was referenced Mar 7, 2021
This was referenced Mar 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
No, tests would require not setting the option (allow default) and running in different environments (TTY vs. non-TTY). Moreover, supports-color has special behaviour for CIs.
Motivation / Use-Case
Since supports-color 5.0.0 (chalk/supports-color#64),
returns an object instead of the test result. Because an object is truthy, colours are enabled by default irrespective of TTY or
FORCE_COLORsettings.is the correct way to use supports-color now.
Breaking Changes
None.
Additional Info