Web Client Build Fix & Instructions Changes - #249
Conversation
Sorry, something went wrong.
|
This looks wrong to me. surface-gl.c will always be compiled due to wildcard usage in the Makefile. |
Sorry, something went wrong.
If I run Makefile.emscripten without the import I added, I see this (I added a log message to find out the value of RENDER_GL on my side): paulaldrich@Pauls-MacBook-Pro rsc-c % make -f Makefile.emscripten
This is an informational message.
RENDER_GL is 1.
emcc -fwrapv -std=gnu99 -s USE_SDL=2 -DSDL2 -I ./cglm/include -DRENDER_GL -s USE_SDL_IMAGE=2 -s SDL2_IMAGE_FORMATS='["png"]' -s -O3 -ffast-math -flto -s DISABLE_EXCEPTION_THROWING=1 -c -o src/surface.o src/surface.c
clang: warning: argument unused during compilation: '-s' [-Wunused-command-line-argument]
src/surface.c:145:5: error: call to undeclared function 'surface_gl_new'; ISO
C99 and later do not support implicit function declarations
[-Wimplicit-function-declaration]
145 | surface_gl_new(surface, width, height, limit, mud);
| ^
1 error generated.
make: *** [src/surface.o] Error 1
So the import seems to be necessary? (see below update) |
Sorry, something went wrong.
… build, added missing definition of surface_gl_new in surface.h which fixes the 'call to undeclared function surface_gl_new' issue
…le/rsc-c into iOS-And-Windows-Changes
|
OK, I fixed a couple things. I removed the #include because it was causing symbols to be defined twice when running make. I then added surface_gl_new to the surface.h file which fixes the call to undeclared function error. Let me know if I should revert the change to mudclient.wasm.js. If so, we may want to consider adding it to .gitignore. |
Sorry, something went wrong.
…tions are any more useful:
…ng that should be committed
What's Changed
Fixes #248