FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

4.24.2 Upgrade - Fixed all compiler Errors and Warnings. by SaxonRah · Pull Request #833 · 20tab/UnrealEnginePython · GitHub

  1. 20tab
  2. UnrealEnginePython

Repository navigation

4.24.2 Upgrade - Fixed all compiler Errors and Warnings. - #833

Open
SaxonRah wants to merge 9 commits into
20tab:masterfrom
SaxonRah:master
ConversationCommits (9)ChecksFiles changed
Open

4.24.2 Upgrade - Fixed all compiler Errors and Warnings. #833
SaxonRah wants to merge 9 commits into
20tab:masterfrom
SaxonRah:master

Conversation

SaxonRah commented Feb 16, 2020

Copy link
Copy Markdown

I ran the editor for over eight hours, no crashes.
Ran a bunch of Python scripts. Nothing seemed to be broken.

OS: Windows 10
Python: 3.6.0

riandrake commented Feb 17, 2020

Copy link
Copy Markdown

Thanks for this! I did see two warnings when compiling though:

2>UEPyActor.cpp(798): warning C4996: 'AActor::GetComponentsByClass': Use one of the GetComponents implementations as appropriate Please update your code to the new API before upgrading to the next release, otherwise your project will no longer compile.
2>  C:\Program Files\Epic Games\UE_4.24\Engine\Source\Runtime\Engine\Classes\GameFramework/Actor.h(2881): note: see declaration of 'AActor::GetComponentsByClass'

2>UEPySTextBlock.cpp(14): warning C4996: 'STextBlock::SetText': SetText taking FString is deprecated. Use the FText version instead Please update your code to the new API before upgrading to the next release, otherwise your project will no longer compile.
2>  C:\Program Files\Epic Games\UE_4.24\Engine\Source\Runtime\Slate\Public\Widgets/Text/STextBlock.h(171): note: see declaration of 'STextBlock::SetText'

SaxonRah commented Feb 17, 2020 •
edited
Loading

Copy link
Copy Markdown
Author

Thanks for this! I did see two warnings when compiling though:

2>UEPyActor.cpp(798): warning C4996: 'AActor::GetComponentsByClass': Use one of the GetComponents implementations as appropriate Please update your code to the new API before upgrading to the next release, otherwise your project will no longer compile.
2>  C:\Program Files\Epic Games\UE_4.24\Engine\Source\Runtime\Engine\Classes\GameFramework/Actor.h(2881): note: see declaration of 'AActor::GetComponentsByClass'

2>UEPySTextBlock.cpp(14): warning C4996: 'STextBlock::SetText': SetText taking FString is deprecated. Use the FText version instead Please update your code to the new API before upgrading to the next release, otherwise your project will no longer compile.
2>  C:\Program Files\Epic Games\UE_4.24\Engine\Source\Runtime\Slate\Public\Widgets/Text/STextBlock.h(171): note: see declaration of 'STextBlock::SetText'

No, Thank you! I wasn't completely sure if my compilation was missing some of the warnings, looks like my suspicion was correct! I'll fix em up soon and update the PR.

HarryMolina commented Feb 21, 2020 via email

Copy link
Copy Markdown

Adanteh commented Mar 15, 2020

Copy link
Copy Markdown

Is this supposed to be launchable now? New to this and only tried the 4.24 version.

Plugins/UnrealEnginePython/Source/UnrealEnginePython/Private/Slate/UEPyFMenuBuilder.cpp(2): fatal error C1083: Cannot open include file: 'IAssetTools.h': No such file or directory
Seems like it's preventing me from launching.

gschweig-amz commented Mar 16, 2020

Copy link
Copy Markdown

bind_event lets the engine crash !

gschweig-amz commented Mar 17, 2020

Copy link
Copy Markdown

Is this supposed to be launchable now? New to this and only tried the 4.24 version.

Plugins/UnrealEnginePython/Source/UnrealEnginePython/Private/Slate/UEPyFMenuBuilder.cpp(2): fatal error C1083: Cannot open include file: 'IAssetTools.h': No such file or directory
Seems like it's preventing me from launching.

I had to remove the IAssetTools.h include from that file.

boristsr mentioned this pull request May 7, 2020
Open
AJIADb9 reviewed May 26, 2020
View reviewed changes
Comment thread Source/UnrealEnginePython/Private/Slate/UEPyFMenuBuilder.cpp
@@ -1,5 +1,5 @@
#include "UEPyFMenuBuilder.h"

#include "IAssetTools.h"

AJIADb9 May 26, 2020

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

#if WITH_EDITOR

HiIAmMoot commented Feb 12, 2021 •
edited
Loading

Copy link
Copy Markdown

When launching I get this exception:
Unhandled exception at 0x00007FFA99A4DACE (ucrtbase.dll) in UE4Editor.exe: Fatal program exit requested.

It exceptions at line 483 at UnrealEnginePython.cpp

_setmode(_fileno(stdin), O_TEXT); _setmode(_fileno(stdout), O_TEXT); _setmode(_fileno(stderr), O_TEXT);

I'm using anaconda3 as my python base.

EDIT: Seems like it was indeed anaconda, or it was one of my installed modules. Tried with a clean python install and it worked fine.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
AJIADb9 AJIADb9 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

Back | FazBrowse Home | New Git URL