Don't hijack a caller-configured JAX compilation cache - #451
Open
eltsai wants to merge 1 commit into
Open
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
e2e testgrid: https://8bcf50593faf4ea38060e236169827e5-dot-us-central1.composer.googleusercontent.com/dags/maxdiffusion_tpu_e2e/grid |
Sorry, something went wrong.
syhuang22
approved these changes
Jul 24, 2026
entrpn
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
run_wan_fast_inference.sh hardcoded all three of its caches under
$HOME/.cache/maxdiffusion_wan, including jax_cache_dir. Because a
jax_cache_dir= on the command line beats the yaml file and
JAX_COMPILATION_CACHE_DIR (pyconfig.py:141-142 calls
jax.config.update), the script silently redirected an
already-configured JAX cache to its own private root, as well as the
55G converted-weights dir. This PR fixes this.