FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Include test_assets from GCS in tpu/gpu dockerfiles by SurbhiJainUSC · Pull Request #2898 · AI-Hypercomputer/maxtext · GitHub

/ maxtext Public

Include test_assets from GCS in tpu/gpu dockerfiles - #2898

Merged
copybara-service[bot] merged 1 commit into
mainfrom
tests_docker_image
Dec 30, 2025
ConversationCommits (1)ChecksFiles changed
Merged

Include test_assets from GCS in tpu/gpu dockerfiles#2898
copybara-service[bot] merged 1 commit into
mainfrom
tests_docker_image

Conversation

SurbhiJainUSC commented Dec 29, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Description

  • Include test_assets from GCS in TPU/GPU docker images build nightly

FIXES: b/471848644

Tests

https://github.com/AI-Hypercomputer/maxtext/actions/runs/20602930239/job/59172412583

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code. For an optional AI review, add the gemini-review label.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in our documentation.

SurbhiJainUSC marked this pull request as ready for review December 29, 2025 22:20

codecov Bot commented Dec 29, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

shuningjin approved these changes Dec 29, 2025
View reviewed changes

shuningjin left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thank you for the quick fix!

copybara-service Bot merged commit 998b3e3 into main Dec 30, 2025
33 checks passed
copybara-service Bot deleted the tests_docker_image branch December 30, 2025 18:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

shuningjin shuningjin approved these changes
RissyRan RissyRan approved these changes
gobbleturk Awaiting requested review from gobbleturk gobbleturk is a code owner
khatwanimohit Awaiting requested review from khatwanimohit khatwanimohit is a code owner
shralex Awaiting requested review from shralex shralex is a code owner
parambole Awaiting requested review from parambole parambole is a code owner
bvandermoon Awaiting requested review from bvandermoon bvandermoon is a code owner
richjames0 Awaiting requested review from richjames0 richjames0 is a code owner

Assignees

No one assigned

Labels

pull ready

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL