FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Prevent API parse error when names contain quotes by fibbers · Pull Request #66 · ActiveCampaign/postmark-java · GitHub

/ postmark-java Public

Prevent API parse error when names contain quotes #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fibbers wants to merge 1 commit into
base: main
Choose a base branch
Could not load branches
Branch not found: {{ refName }}

Are you sure you want to change the base?

Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
from
Conversation 3 Commits 1 Checks 0 Files changed
Open

Prevent API parse error when names contain quotes #66

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension .java  (2) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
4 changes: 4 additions & 0 deletions src/main/java/com/postmarkapp/postmark/client/data/model/message/BaseMessage.java
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -367,6 +367,10 @@ private String convertRecipients(List<String> recipients) {

private String convertRecipient(String name, String address) {
StringBuilder recipientsString = new StringBuilder();
if (name != null) {
// Escape characters that otherwise cause parsing errors in the API
name = name.replace("\"", "\\\"");
}
return recipientsString.append("\"").append(name).append("\"")
.append("<").append(address).append(">").toString();
}
Expand Down
22 changes: 22 additions & 0 deletions src/test/java/unit/data/MessageTest.java
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,28 @@ void simpleMessageBcccRecipientsFullName() throws IOException {

}

@Test
void recipientsWithQuotesAreEscapedProperly() {
Message message = new Message();
String nameWithQuote = "John \"Smith\"";
String email = "john@example.com";

Map<String, String> recipients = new HashMap<>();
recipients.put(nameWithQuote, email);

message.setTo(recipients);
assertEquals("\"John \\\"Smith\\\"\"<john@example.com>", message.getTo());

message.setCc(recipients);
assertEquals("\"John \\\"Smith\\\"\"<john@example.com>", message.getCc());

message.setBcc(recipients);
assertEquals("\"John \\\"Smith\\\"\"<john@example.com>", message.getBcc());

message.setFrom(nameWithQuote, email);
assertEquals("\"John \\\"Smith\\\"\"<john@example.com>", message.getFrom());
}

@Test
void attachmentException() throws IOException {
Message message = new Message();
Expand Down
Back | FazBrowse Home | New Git URL