Clean up command prompt logging - #1004
Merged
jpn-- merged 20 commits intoOct 28, 2025
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
… level to "debug" level
…"INFO" to "DEBUG"
…) from 20 to 10 so that it's a DEBUG message by default
…ves from "INFO" to "DEBUG"
…it's repetitive and will likely only be of concern during development/debugging
…and simulation in trip destination choice from "INFO" to "DEBUG"
jpn--
self-requested a review
October 28, 2025 17:36
jpn--
approved these changes
Oct 28, 2025
jpn--
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
I have reviewed this and found it works as described. There are a few stray messages we could still get and remove from the main logs but that need not hold up approving this.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request cleans up the logging that was raised in #408, primarily by downgrading multiple instances of logger.info() to logger.debug(). Guidance on what logging level to use for each logging message was also added to the logging documentation. Statements were targeted for demotion by running the prototype_mtc example with the logging level set to INFO and prioritizing statements that were repetitive and not helpful for simply determining where the model was at (but could be useful for debugging). The changes in this pull request result in the size of the output logfile (and by proxy number of messages printed in the console) for the prototype_mtc example decreasing from 3290 KB to 139 KB, a 95.8% reduction.