Implement deletion of temporary variables in summarize.py - #1062
Open
ziocolaandrea wants to merge 1 commit into
Open
Implement deletion of temporary variables in summarize.py#1062ziocolaandrea wants to merge 1 commit into
ziocolaandrea wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Add functionality to delete temporary variables starting with '_del' from locals_d.
Comment thread
activitysim/abm/models/summarize.py
Comment on lines
+369
to
+373
| logger.debug(f"Deleting temporary variable: {expr}") | ||
| with performance_timer.time_expression(expr): | ||
| exec(f"del {expr}", globals(), locals_d) | ||
| for var in expr.split(","): | ||
| locals_d.pop(var.strip(), None) |
Comment thread
activitysim/abm/models/summarize.py
| out_file = row["Output"] | ||
| expr = row["Expression"] | ||
|
|
||
| # delete temporary variables starting with '_del' from locals_d |
Comment thread
activitysim/abm/models/summarize.py
Comment on lines
+368
to
+374
| if out_file == "_del": | ||
| logger.debug(f"Deleting temporary variable: {expr}") | ||
| with performance_timer.time_expression(expr): | ||
| exec(f"del {expr}", globals(), locals_d) | ||
| for var in expr.split(","): | ||
| locals_d.pop(var.strip(), None) | ||
| continue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Assignees
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While running the summarise step I ran into memory allocation issues.
I tested adding the deletion of temporary variables not used in subsequent summaries and managed to go through the step.