FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add WITH FILL Support in ORDER BY by Flo4604 · Pull Request #211 · AfterShip/clickhouse-sql-parser · GitHub

/ clickhouse-sql-parser Public

Add WITH FILL Support in ORDER BY - #211

Merged
git-hulk merged 6 commits into
AfterShip:masterfrom
Flo4604:feat/add-order-by-with-fill-support
Nov 7, 2025
ConversationCommits (6)ChecksFiles changed
Merged

Add WITH FILL Support in ORDER BY #211
git-hulk merged 6 commits into
AfterShip:masterfrom
Flo4604:feat/add-order-by-with-fill-support

Conversation

Flo4604 commented Nov 7, 2025

Copy link
Copy Markdown
Contributor

coveralls commented Nov 7, 2025 •
edited
Loading

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 19169478931

Details

  • 158 of 262 (60.31%) changed or added relevant lines in 4 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.2%) to 50.865%
Changes Missing Coverage Covered Lines Changed/Added Lines %
parser/parser_table.go 80 84 95.24%
parser/ast_visitor.go 0 15 0.0%
parser/walk.go 13 31 41.94%
parser/ast.go 65 132 49.24%
Files with Coverage Reduction New Missed Lines %
parser/ast.go 2 40.37%
Totals
Change from base Build 19155524800: 0.2%
Covered Lines: 7821
Relevant Lines: 15376
💛 - Coveralls

git-hulk self-requested a review November 7, 2025 11:46
git-hulk reviewed Nov 7, 2025
View reviewed changes

git-hulk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@Flo4604 Thanks for your improvement. Generally looks pretty good to me, left two code style comments.

Comment thread parser/parser_table.go Outdated
Comment thread parser/parser_table.go Outdated
git-hulk merged commit 06f1e25 into AfterShip:master Nov 7, 2025
1 check passed

git-hulk commented Nov 7, 2025

Copy link
Copy Markdown
Member

@Flo4604 Thank you!

Flo4604 deleted the feat/add-order-by-with-fill-support branch November 7, 2025 13:27

Flo4604 commented Nov 7, 2025

Copy link
Copy Markdown
Contributor Author

Thank you! Awesome project

is it possible to get a new tag or is there a release schedule

git-hulk commented Nov 7, 2025

Copy link
Copy Markdown
Member

@Flo4604 Pushed the new tag v0.4.16.

Flo4604 commented Nov 7, 2025

Copy link
Copy Markdown
Contributor Author

thank you 👏

Flo4604 mentioned this pull request Nov 7, 2025
Merged
19 tasks
BrewTestBot mentioned this pull request Nov 20, 2025
Merged
orian referenced this pull request in orian/clickhouse-sql-parser May 13, 2026
Add WITH FILL Support in ORDER BY (#211)
1d1db3f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

git-hulk git-hulk approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL