Fix nil pointer for replicated database engine - #212
Merged
git-hulk merged 1 commit intoNov 17, 2025
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
git-hulk
approved these changes
Nov 17, 2025
git-hulk
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
@rabenhorst Good catch!
Sorry, something went wrong.
Copy link
Copy Markdown
Pull Request Test Coverage Report for Build 19428897560Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Sorry, something went wrong.
orian
referenced
this pull request
in orian/clickhouse-sql-parser
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a bug in the parseCreateDatabase which results in nil pointer when setting the engine for a replicated database, because it sets StatementEnd to onCluster.End() after checking if engineExpr is nil.
clickhouse-sql-parser/parser/parser_table.go
Lines 102 to 104 in c9e8bb4
In this PR this is fixed and test case for replicated database is added.