bug: fix a crash with an invalid query following MODIFY QUERY - #215
Merged
git-hulk merged 1 commit intoNov 20, 2025
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
ALTER TABLE foo MODIFY QUERY <an invalid query> crashed the parser with a sigsegv due to a missing error check; this commit adds the missing check and a regression test.
Copy link
Copy Markdown
Pull Request Test Coverage Report for Build 19513181714Details
💛 - Coveralls |
Sorry, something went wrong.
git-hulk
approved these changes
Nov 20, 2025
Copy link
Copy Markdown
Member
|
@swgillespie Thanks for your great catch! |
Sorry, something went wrong.
orian
referenced
this pull request
in orian/clickhouse-sql-parser
May 13, 2026
ALTER TABLE foo MODIFY QUERY <an invalid query> crashed the parser with a sigsegv due to a missing error check; this commit adds the missing check and a regression test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ALTER TABLE foo MODIFY QUERY crashed the parser with a sigsegv due to a missing error check; this commit adds the missing check and a regression test.