FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

BugFix: Refreshable View with named parameters by sharadgaur · Pull Request #217 · AfterShip/clickhouse-sql-parser · GitHub

/ clickhouse-sql-parser Public

BugFix: Refreshable View with named parameters - #217

Merged
git-hulk merged 4 commits into
AfterShip:masterfrom
sharadgaur:sharad/named_parameter_v1
Nov 21, 2025
ConversationCommits (4)ChecksFiles changed
Merged

BugFix: Refreshable View with named parameters#217
git-hulk merged 4 commits into
AfterShip:masterfrom
sharadgaur:sharad/named_parameter_v1

Conversation

sharadgaur commented Nov 20, 2025

Copy link
Copy Markdown
Contributor

Fix for this #216

BugFix: Refreshable View with named parameters
92cf14f 
Signed-off-by: Sharad Gaur <sharadgaur@gmail.com>
Fixing
3ba1616 
Signed-off-by: Sharad Gaur <sharadgaur@gmail.com>
Removing unwanted code
fe17149 
Signed-off-by: Sharad Gaur <sharadgaur@gmail.com>

coveralls commented Nov 20, 2025 •
edited
Loading

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 19557576815

Details

  • 46 of 77 (59.74%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 51.054%
Changes Missing Coverage Covered Lines Changed/Added Lines %
parser/walk.go 3 7 42.86%
parser/ast_visitor.go 0 5 0.0%
parser/parser_table.go 36 42 85.71%
parser/ast.go 7 23 30.43%
Totals
Change from base Build 19522671202: 0.04%
Covered Lines: 7943
Relevant Lines: 15558
💛 - Coveralls

git-hulk commented Nov 21, 2025

Copy link
Copy Markdown
Member

@sharadgaur Thanks for your quick fix.

The PR looks good to me. Could you please add NamedParameterExpr to walk.go? So that we could visit this expression while walking through the AST.

Adding to walk.go
f8c2a1f 
Signed-off-by: Sharad Gaur <sharadgaur@gmail.com>

sharadgaur commented Nov 21, 2025

Copy link
Copy Markdown
Contributor Author

@sharadgaur Thanks for your quick fix.

The PR looks good to me. Could you please add NamedParameterExpr to walk.go? So that we could visit this expression while walking through the AST.

Done

git-hulk commented Nov 21, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

@sharadgaur Thanks for your great work.

git-hulk merged commit 699e78f into AfterShip:master Nov 21, 2025
2 checks passed
orian referenced this pull request in orian/clickhouse-sql-parser May 13, 2026
Fix refreshable View with named parameters (#217)
cc76c5d 
* Removing unwanted code

Signed-off-by: Sharad Gaur <sharadgaur@gmail.com>

* Adding to walk.go

Signed-off-by: Sharad Gaur <sharadgaur@gmail.com>

---------

Signed-off-by: Sharad Gaur <sharadgaur@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

git-hulk git-hulk approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL