Support empty parentheses in index type definitions - #224
Conversation
Sorry, something went wrong.
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Sorry, something went wrong.
Pull Request Test Coverage Report for Build 20059659103Details
💛 - Coveralls |
Sorry, something went wrong.
There was a problem hiding this comment.
Pull request overview
This PR adds support for parsing index type definitions with empty parentheses (e.g., TYPE bloom_filter()). Previously, the parser only handled types with parameters like bloom_filter(0.001) or types without parentheses at all. The fix allows the parser to correctly handle the empty parentheses case by returning a TypeWithParams structure with Params: nil.
Key Changes
- Added a new case in parseColumnType() to handle TokenKindRParen immediately after the opening parenthesis
- Returns a properly structured TypeWithParams with nil params for empty parentheses
- Added comprehensive test coverage including input SQL, formatted output, and golden JSON AST
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| parser/parser_column.go | Added new case to handle empty parentheses in type definitions, returning TypeWithParams with nil Params |
| parser/testdata/ddl/create_table_with_index.sql | Added test case with INDEX idx_id idx TYPE bloom_filter() GRANULARITY 1 |
| parser/testdata/ddl/format/create_table_with_index.sql | Updated formatted output to include the new test case with empty parentheses |
| parser/testdata/ddl/output/create_table_with_index.sql.golden.json | Updated golden JSON output showing correct AST structure with Params: null |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sorry, something went wrong.
The parser previously failed on index types like TYPE bloom_filter() because it only handled:
Now correctly parses types with empty parentheses () by returning a TypeWithParams with Params: nil.
Test Case
Added test case with INDEX idx_id idx TYPE bloom_filter() GRANULARITY 1 to verify the fix.