Fix should allow END as a bare column name - #301
Merged
git-hulk merged 1 commit intoAug 4, 2026
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
END is not reserved in ClickHouse; columns named `end` (e.g. CloudQuery's aws_ec2_reserved_instances) failed to parse in function arguments, WHERE, INSERT column lists and CREATE TABLE since it joined reservedKeywords. CASE still requires END because parseColumnCaseExpr expects it explicitly.
erezrokah
marked this pull request as ready for review
August 3, 2026 15:52
git-hulk
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make END non-reserved again so columns named end parse, since ClickHouse does not reserve it.
END joined reservedKeywords in #282, which broke end as a bare column name everywhere except the few lookahead-disambiguated positions:
SELECT end FROM t, GROUP BY end and ORDER BY end already worked, which made the breakage look partial.
CASE is unaffected: parseColumnCaseExpr expects the END keyword explicitly, so CASE WHEN a THEN 1 ELSE 2 FROM t still errors (covered by a new test) — same as ClickHouse, which reports a syntax error for it.
All of the above statements were verified against clickhouse local 26.7.1 (Docker clickhouse/clickhouse-server:latest).
Tests: cases added to TestNonReservedKeywordAsIdentifier, new TestCaseExprRequiresEnd, and fixture parser/testdata/query/select_end_as_column_name.sql with regenerated goldens.