Add support for DROP DATABASE ... SYNC - #309
Merged
git-hulk merged 1 commit intoAug 6, 2026
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Sorry, something went wrong.
DROP DATABASE accepts the same SYNC and NO DELAY modifiers as DROP TABLE, but only parseDropStmt handled them, so these were rejected: DROP DATABASE IF EXISTS test_db SYNC DROP DATABASE IF EXISTS test_db ON CLUSTER akvorado SYNC Reuse tryParseModifier, which DROP TABLE and DROP USER already share.
vincentbernat
force-pushed
the
fix/drop-database-sync
branch
from
206f0de to
e9a3a6d
Compare
August 5, 2026 13:39
git-hulk
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DROP DATABASE accepts the same SYNC and NO DELAY modifiers as DROP
TABLE, but only parseDropStmt handled them, so these were rejected:
DROP DATABASE IF EXISTS test_db SYNC
DROP DATABASE IF EXISTS test_db ON CLUSTER akvorado SYNC
Reuse tryParseModifier, which DROP TABLE and DROP USER already share.