Added a List Comprehension topic - #34
Conversation
Sorry, something went wrong.
Adding additional .md file for list comprehension
Added information to list-comprehension.md
Akuli
left a comment
There was a problem hiding this comment.
Thanks! A few comments below.
Sorry, something went wrong.
| 19. [Exceptions](exceptions.md) | ||
| 20. [Classes](classes.md) | ||
| 21. [Docstrings](docstrings.md) | ||
| 22. [List Comprehension](list-comprehension.md) |
There was a problem hiding this comment.
It would be good to have this immediately after loops. (You have to change the numbering.)
Sorry, something went wrong.
| # List Comprehension | ||
|
|
||
|
|
||
| ## Definition |
There was a problem hiding this comment.
This doesn't have to be under a second title.
| ## Definition |
Sorry, something went wrong.
|
|
||
|
|
||
| ## Definition | ||
| List comprehensions creates a new list from an existing list that is a shorter syntax than normal. It also processes the list much faster than using a for loop. |
There was a problem hiding this comment.
- "Shorter than normal" is a bit ambiguous.
- When performance matters, performance problems don't usually come from small things like this, in my experience. Not really worth mentioning.
| List comprehensions creates a new list from an existing list that is a shorter syntax than normal. It also processes the list much faster than using a for loop. | |
| List comprehensions creates a new list from an existing list using shorter syntax than loops. |
Sorry, something went wrong.
| arr = [] | ||
|
|
||
| for i in animals: |
There was a problem hiding this comment.
Consider improving the variable names, e.g. arr --> filtered_animals, i --> animal, also in the list comprehension below.
Sorry, something went wrong.
| print(arr) | ||
| ``` | ||
| ```python | ||
| ['dog', 'cat', 'ape'] |
There was a problem hiding this comment.
It would be good to show the output right at the print statement, so it is clear that it comes from print(arr). It matters more when there's multiple prints, but I think it helps here too.
| print(arr) | |
| ``` | |
| ```python | |
| ['dog', 'cat', 'ape'] | |
| print(arr) # Prints: ['dog', 'cat', 'ape'] |
Sorry, something went wrong.
| ``` | ||
| The example above does exactly the same thing but is in a much more concise syntax where it iterates through the list of animals and appends to the new list if their name is exactly 3 characters long. | ||
|
|
||
| ## Syntax |
There was a problem hiding this comment.
What's the purpose of this section? Reading a description of syntax isn't a good way to learn, in my experience. It would be better to just show the i.lower() example, without trying to describe the syntax with words too much.
Sorry, something went wrong.
| - List comprehensions are a good way to shorten code | ||
| - They are versatile when it comes to iterating through iterable datasets | ||
| - Not only can you filter out data with a condition you can also change the data before it gets added to the new list | ||
| - List comprehensions normally follow: newlist = [**expression** for **item** in **iterable** if **condition**] |
There was a problem hiding this comment.
Add . to the end of each. Also consider removing the last item, if you remove the ## Syntax section.
Sorry, something went wrong.
list-comprehension.md
Taking a class on github and I had to contribute to a repository. So I thought contributing to a python-tutorial would be interesting. I can add or change more things if needed.