Alchemist effects in human-readable format - #7
DanySK merged 8 commits into
Conversation
Sorry, something went wrong.
|
Including that file is a no-go. We have not the power to maintain our own pieces of Gson. If you need a newer version of Gson, then please check if it's already there in Maven Central |
Sorry, something went wrong.
backward compatibility: effects are deserialized from binary files as well but from now on are serialized only in JSON format
| this.loadButton.setEnabled(value); | ||
| this.moveLeftButton.setEnabled(value); | ||
| this.moveRightButton.setEnabled(value); | ||
| for (final Component c : this.stackSec.getComponents()) { |
There was a problem hiding this comment.
Not a problem - but why this "this" invasion? Where they necessary, or was it the setting of your editor? If so, be wary: in many cases, abusing this. leads to unnecessary hyperverbose code (and java is already verbose itselft)
Sorry, something went wrong.
There was a problem hiding this comment.
My bad. I am used to using this setting. I will get rid of "this" invasion
Sorry, something went wrong.
Effects are stored in human readable format.
I added a serialization factory to centralize effects serialization. Future changes in serialization will affect only this class.
I had to include RuntimeTypeAdapterFactory.java from the Gson repo as this class is not shipped with the Gson artifact.