feat: ✨ oversample SRC sketches before exact SVD truncation - #63
Merged
Panadestein merged 8 commits intoOct 15, 2026
Merged
Panadestein merged 8 commits into
Panadestein merged 8 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Assisted-by: GitHub Copilot:unknown Co-authored-by: robertodr <3708689+robertodr@users.noreply.github.com>
Assisted-by: GitHub Copilot:unknown Co-authored-by: robertodr <3708689+robertodr@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix oversampled sketch followed by exact SVD truncation
feat: ✨ oversample SRC sketches before exact SVD truncation
Oct 14, 2026
Panadestein
marked this pull request as ready for review
October 15, 2026 08:23
Copy link
Copy Markdown
Contributor
Test Results 5 files ± 0 5 suites ±0 4m 17s ⏱️ +40s Results for commit 8c0663e. ± Comparison against base commit a996df3. This pull request removes 11 and adds 119 tests. Note that renamed tests count towards both.tests.test_stack ‑ test_apply_matches_src[A B-0.0] tests.test_stack ‑ test_apply_matches_src[A B-0.5] tests.test_stack ‑ test_apply_matches_src[A psi-0.0] tests.test_stack ‑ test_apply_matches_src[A psi-0.5] tests.test_stack ‑ test_compress_matches_src[A-0.0] tests.test_stack ‑ test_compress_matches_src[A-0.5] tests.test_stack ‑ test_compress_matches_src[psi-0.0] tests.test_stack ‑ test_compress_matches_src[psi-0.5] tests.test_stack ‑ test_src_two_site_stack_falls_back[A B C] tests.test_stack ‑ test_src_two_site_stack_falls_back[A B psi] … tests.test_gpu_backend ‑ test_oversampled_truncation_matches_cpu[mpo-1.0] tests.test_gpu_backend ‑ test_oversampled_truncation_matches_cpu[mpo-2.0] tests.test_gpu_backend ‑ test_oversampled_truncation_matches_cpu[mpo-None] tests.test_gpu_backend ‑ test_oversampled_truncation_matches_cpu[mps-1.0] tests.test_gpu_backend ‑ test_oversampled_truncation_matches_cpu[mps-2.0] tests.test_gpu_backend ‑ test_oversampled_truncation_matches_cpu[mps-None] tests.test_stack ‑ test_apply_matches_src[A B-0.0-1.0] tests.test_stack ‑ test_apply_matches_src[A B-0.0-1.5] tests.test_stack ‑ test_apply_matches_src[A B-0.0-None] tests.test_stack ‑ test_apply_matches_src[A B-0.5-1.0] … ♻️ This comment has been updated with latest results. |
Sorry, something went wrong.
Assisted-by: GitHub Copilot:claude-sonnet-5.5
Assisted-by: GitHub Copilot:claude-sonnet-5.5
Assisted-by: GitHub Copilot:claude-opus-5.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Assignees
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI text below 🤖
Sketching at exactly chi_out makes randomized range-finding error dominate SRC accuracy. This change oversamples first, then truncates to the requested bond dimension.