FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

tpcdigits.root readout by ChSonnabend · Pull Request #14604 · AliceO2Group/AliceO2 · GitHub

/ AliceO2 Public

tpcdigits.root readout - #14604

Closed
ChSonnabend wants to merge 4 commits into
AliceO2Group:devfrom
ChSonnabend:tpcdigtis_readout
ConversationCommits (4)ChecksFiles changed
Closed

tpcdigits.root readout#14604
ChSonnabend wants to merge 4 commits into
AliceO2Group:devfrom
ChSonnabend:tpcdigtis_readout

Conversation

ChSonnabend commented Aug 20, 2025

Copy link
Copy Markdown
Collaborator

What do you think @sawenzel and @davidrohr ?
This way the digits are streamed out, but the reco (with --input-type digits) until track-level doesn't yet work without --disable-mc.

github-actions Bot commented Aug 20, 2025

Copy link
Copy Markdown
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

alibuild mentioned this pull request Aug 20, 2025
Merged
ChSonnabend added a commit to ChSonnabend/AliceO2 that referenced this pull request Aug 20, 2025
Merge pull request #33 from alibuild/alibot-cleanup-14604
961be14 
Please consider the following formatting changes to AliceO2Group#14604
sawenzel reviewed Aug 20, 2025
View reviewed changes
Comment thread Detectors/TPC/workflow/src/ChunkedDigitPublisher.cxx
#include "DetectorsRaw/HBFUtilsInitializer.h"
#include "TPCSimulation/CommonMode.h"
#include "DetectorsBase/Detector.h"
#include "DPLUtils/MakeRootTreeWriterSpec.h"

sawenzel Aug 20, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

In the normal TPC digitizer workflow, we employ a specialized header TPCDigitRootWriterSpec.h which defines a Writer class for TPC digits. I would try to utilize this. Likely it offers correct treatment for the MC truth classes.

ChSonnabend marked this pull request as draft August 20, 2025 13:17
alibuild mentioned this pull request Aug 20, 2025
Closed

sawenzel commented Aug 21, 2025

Copy link
Copy Markdown
Collaborator

Closing in favour of #14608.

sawenzel closed this Aug 21, 2025
ChSonnabend deleted the tpcdigtis_readout branch August 21, 2025 14:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

sawenzel sawenzel left review comments
davidrohr Awaiting requested review from davidrohr davidrohr is a code owner
wiechula Awaiting requested review from wiechula wiechula is a code owner
shahor02 Awaiting requested review from shahor02 shahor02 is a code owner

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL