FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

CTP: luminosity workflow by Elladt · Pull Request #15708 · AliceO2Group/AliceO2 · GitHub

/ AliceO2 Public

CTP: luminosity workflow - #15708

Merged
sawenzel merged 7 commits into
AliceO2Group:devfrom
Elladt:ctplumi
Aug 26, 2026
ConversationCommits (7)ChecksFiles changed
Merged

CTP: luminosity workflow#15708
sawenzel merged 7 commits into
AliceO2Group:devfrom
Elladt:ctplumi

Conversation

Elladt commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Added workflow for calculating luminosity

Elladt requested a review from a team as a code owner August 21, 2026 14:48
alibuild mentioned this pull request Aug 21, 2026
Closed

Elladt commented Aug 21, 2026

Copy link
Copy Markdown
Contributor Author

@lietava Here is the pull request

lietava commented Aug 21, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Hi @Elladt , thanks.

lietava commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

@shahor02 : why the checks are pending ?

shahor02 previously approved these changes Aug 23, 2026
View reviewed changes

shahor02 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Approving conditionally to trigger CI.

@lietava @Elladt could you please comment on where and how this workflow should be used? Its DPL output is the same as of the CTP/workflow/src/RawDecoderSpec.cxx, and the code seems to be largely cloned from the latter.

alibuild commented Aug 23, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2/fullCI_slc9 for ea1b2de at 2026-08-23 15:24:

## sw/BUILD/O2-latest/log
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/CTP/workflowLumi/src/RawDecoderSpec.cxx:419:22: error: 'create_directories' is not a member of 'std::filesystem'
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/CTP/workflowLumi/src/RawDecoderSpec.cxx:440:20: error: 'create_directories' is not a member of 'std::filesystem'
ninja: build stopped: subcommand failed.

Full log here.

lietava commented Aug 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Uploading Ella_Summer_Student_Report.pdf…
Hi @shahor02 , it is work in progress done by summer student @Elladt .
The goal is to replace non o2 ctp sw which creates massi files and maybe more things.
It is to be discussed with lhcif and to be employed before run4.

shahor02 commented Aug 24, 2026

Copy link
Copy Markdown
Collaborator

@lietava the CI errors are genuine (missing includes?)

lietava commented Aug 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

HI @shahor02 , yes include filesystem seems to solve problem.
Can I push to this PR ?

shahor02 commented Aug 25, 2026

Copy link
Copy Markdown
Collaborator

@lietava no, but I've added the include by direct edit.

lietava commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

@shahor02 , thanks.

shahor02 previously approved these changes Aug 26, 2026
View reviewed changes

shahor02 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

re-approving conditionally to restart CI

alibuild commented Aug 26, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2/fullCI_slc9 for 877c9d4 at 2026-08-26 12:26:

## sw/BUILD/ThePEG-latest/log
collect2: error: ld returned 1 exit status


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/CTP/workflowLumi/src/RawDecoderSpec.cxx:328:29: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/CTP/workflowLumi/src/RawDecoderSpec.cxx:330:29: error: statement should be inside braces [readability-braces-around-statements]
++ [[ 0 == 0 ]]
++ exit 1
--

Full log here.

shahor02 previously approved these changes Aug 26, 2026
View reviewed changes

shahor02 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

restart CI

alibuild mentioned this pull request Aug 26, 2026
Closed
sawenzel merged commit 3a66565 into AliceO2Group:dev Aug 26, 2026
10 of 11 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

shahor02 shahor02 approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL