| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Add GaqSummaryRepository and GaqSummaryInvalidationRepository and export them from the repositories index. Update migration to replace the previous invalidated_at field with created_at and add updated_at to mirror default Sequelize tables.
Rename and change mcReproducible to be the coverage float not the boolean.
Forgot to remove.
Add GAQ summary invalidation whenever underlying data affecting GAQ changes. These changes ensure GAQ summary caches/records are marked for recomputation whenever detectors, QC flags, or run QC times that influence GAQ summaries are modified.
…e/O2B-1563/Create-GAQ-summary-invalidation-mechanism
Validate GAQ summary invalidation behaviour on QC flag create/verify/delete, deleteAllForDataPass, explicit/default GAQ detector changes, and run QC time updates.
Add a calculation_failed boolean column to gaq_summaries. This allows us to know whether a summary has been attempted to be calculated but unsuccessful due to limited data etc.
…e/O2B-1563/Create-GAQ-summary-invalidation-mechanism
Remove not-null constraints from several GAQ summary columns in the migration to allow NULL when values are unavailable.
…e/O2B-1563/Create-GAQ-summary-invalidation-mechanism
Store invalidation timestamp directly on gaq_summaries instead of a separate gaq_summary_invalidations table.
…e/O2B-1563/Create-GAQ-summary-invalidation-mechanism
…e/O2B-1563/Create-GAQ-summary-invalidation-mechanism
Replace usage of GaqSummaryInvalidationRepository with GaqSummaryRepository across services and tests. Upsert calls now set an invalidatedAt timestamp to mark GAQ summaries as invalidated.
Create an index on invalidated_at column of gaq_summaries table to improve query performance, as it is commonly used to fetch the invalidated summary queue.
…e/O2B-1563/Create-GAQ-summary-invalidation-mechanism
…already soft deleted The simplest way of invalidating GAQ summaries affected by the deletion of a dataPass' Flags is to just take the list of deleted flags. But this is inefficient if some flags were already deleted and thus had already had their summaries at the time.
Sequelize model omitted the primaryKey that migration file defines.
…e/O2B-1563/Create-GAQ-summary-invalidation-mechanism
Extract invalidation into helpers. Guard GAQ updateRun reload so don't run reload unnecessarily. Add to notComputable field in model allowNull default params. Add more test coverage for invalidation on run patch.
Codecov Report❌ Patch coverage is 91.93548% with 5 lines in your changes missing coverage. Please review.
@@ Coverage Diff @@
## main #2174 +/- ##
==========================================
+ Coverage 45.82% 46.19% +0.36%
==========================================
Files 1039 1042 +3
Lines 17189 17229 +40
Branches 3138 3142 +4
==========================================
+ Hits 7877 7959 +82
+ Misses 9312 9270 -42 ☔ View full report in Codecov by Harness.
|
Sorry, something went wrong.
…e/O2B-1563/Create-GAQ-summary-invalidation-mechanism
…-invalidation-mechanism" This reverts commit 23f6e04.
| Back | FazBrowse Home | New Git URL |
I have a JIRA ticket
Notable changes for users:
Notable changes for developers:
Changes made to the database:
Will invalidate a GAQ summary row, if present or otherwise, if an identified trigger occurs (see JIRA ticket).
Simply calls a GAQ summary repository helper to create the invalidation from each triggers code.