FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[O2B-1605] Use detectors rather than sync detectors as per inherited prop by graduta · Pull Request #2213 · AliceO2Group/Bookkeeping · GitHub

/ Bookkeeping Public

[O2B-1605] Use detectors rather than sync detectors as per inherited prop - #2213

Merged
graduta merged 2 commits into
mainfrom
improv/O2B-1605/use-detectors-inherited-prop
Aug 17, 2026
ConversationCommits (2)ChecksFiles changed
Merged

[O2B-1605] Use detectors rather than sync detectors as per inherited prop#2213
graduta merged 2 commits into
mainfrom
improv/O2B-1605/use-detectors-inherited-prop

Conversation

graduta commented Aug 17, 2026

Copy link
Copy Markdown
Member

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for developers:

  • all runsPer* models now use the inherited detectors list

graduta self-assigned this Aug 17, 2026
graduta requested a review from isaachilly as a code owner August 17, 2026 10:45

codecov Bot commented Aug 17, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.18%. Comparing base (86dde0e) to head (a759562).

Files with missing lines Patch % Lines
...Runs/RunPerPeriod/RunsPerLhcPeriodOverviewModel.js 0.00% 4 Missing ⚠️
.../Runs/RunPerPeriod/RunsPerLhcPeriodOverviewPage.js 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2213      +/-   ##
==========================================
+ Coverage   46.16%   46.18%   +0.01%     
==========================================
  Files        1040     1040              
  Lines       17163    17160       -3     
  Branches     3133     3133              
==========================================
+ Hits         7923     7925       +2     
+ Misses       9240     9235       -5

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

graduta merged commit 0eb8113 into main Aug 17, 2026
24 of 25 checks passed
graduta deleted the improv/O2B-1605/use-detectors-inherited-prop branch August 17, 2026 12:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

isaachilly Awaiting requested review from isaachilly isaachilly is a code owner

Assignees

graduta

Labels

frontend

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

Back | FazBrowse Home | New Git URL