FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[OGUI-1847] Fix arrays saved as objects and other small fixes by Deaponn · Pull Request #3236 · AliceO2Group/WebUi · GitHub

[OGUI-1847] Fix arrays saved as objects and other small fixes - #3236

Open
Deaponn wants to merge 5 commits into
devfrom
fix/CNF/OGUI-1847/arrays-saved-as-objects
Open

[OGUI-1847] Fix arrays saved as objects and other small fixes#3236
Deaponn wants to merge 5 commits into
devfrom
fix/CNF/OGUI-1847/arrays-saved-as-objects

Conversation

Deaponn commented Dec 15, 2025

Copy link
Copy Markdown
Contributor

This PR fixes a couple of bugs:

  • one where arrays are converted into objects on configuration save ([true, 'text', 99] becomes { 0: true, 1: 'text', 2: 99 })
  • one where edit difference highlighting fails for FormToggleInput component
  • one where empty objects and lists are not parsed correctly which causes them to be lost while saving

I have JIRA issue created

  • branch and/or PR name(s) includes JIRA ID
  • issue "Status" is set to "In review"
  • PR labels are selected

piechnikk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL