AC multi-operation change - #88
Open
bernstbj wants to merge 3 commits into
Open
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
same JVM instance. Multiple commands are specified sequentially (e.g. ac.sh -ptx volume.po afile afile.txt -bas volume.po bfile bfile.bas). This required adding support for several operations to read files instead of STDIN. However, STDIN support remains for those who want to use it, though they need to specify '-' as the file.
Copy link
Copy Markdown
Contributor
|
This is a breaking change to command-line interface. It breaks all existing documentations/ instructions/ tutorials. How about the other way round? Default to stdin and enable file input by a switch. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed command line parsing to allow for multiple operations in the same JVM instance. Multiple commands are specified sequentially (e.g. ac.sh -ptx volume.po afile afile.txt -bas volume.po bfile bfile.bas).
This required adding support for several operations to read files instead of STDIN. However, STDIN support remains for those who want to use it, though they need to specify '-' as the file. (e.g. ac.sh -ptx volume.po afile - <afile.txt)
The point of doing this was that I have a .po that I am writing 1000 files to. Doing this file-by-file with the existing ac.sh mechanism takes nearly 6 minutes because of the constant bring-up/tear-down of a JVM. With this change, the same task can be done in under 20 seconds.