feat: javascript-server by AryanSinghal · Pull Request #28 · AryanSinghal/javascript-server · GitHub

Day 1 - Basic GIT Intro, features of VS CODE

create git account and install vs code

Day 2 - MERN Stack,12 factor app

write about MERN stack and 12 Factor APP stack in detail.

Day 3 - Intro to Node.js & NPM

Create functions for the patterns

Day 4 - Objects and Array

Create file permissions.js and validation.js

Day 5 - Packages in Node.js

install various packages of node

Day 6 - Advantages of TypeScript

use TypeScript

Day 7 - Setup of Express (OOps based)

setup express server

Day 8 -HTTP Status code and handlers

create error hander and not found route

Day 9 - Setting of Routes Skeletons (REST API)

create route for different request

Day 10 -Generic Routes Validations

create middleware

Day 11 - Authentication and Authorization

create authmiddleware

Day 12 - Intro to Mongoose and promises

Setup MongoDB using mongoose

Day 13 - Models setup with initial seed

create initial seeding and model setup for MongoDB

Day 14 - Profile Setup

count check on the seeding of users and create a jwt token by using data from DB

Day 15 - Setup all the Entities

create generic methods like create, update, generateObjectId in versionableRepository

Day 16 - Magic of Await

use bcrypt for encryption of password and use async-await

Day 17 - APIs Completion

Count total no. of trainees, implement Sorting and implement Server Side Pagination.

Day 18 - APIs Completion

implement search on email and name
Implement Swagger on all APIs.

Added commands used

feat: Add VS-CODE.md (#39512)

change format

Docs: features and plugins of vscode (#39512)

feat: MERN Stack,12 factor app (#39513)

feat: Intro to Node.js & NPM (#39515)

No proper indentation is done over here in this file

No indentation in file

Do we really need else statement over here?

no, we do not need else statement

No indentation is done

If we are getting value as first argument then why do we need to extract value using index?

Please a proper space between import statements and calling of functions.

Export at the end of file with single export statement.

What if value of data[permissionType] is null?

One line space is needed.

Better to name it TraineeController

Why are converting name to lowercase?

Why do not we do it using the validation handler by using custom function?

Because I have to make a custom function that will return a promise and i have to handle promise which will make my validation handler non-generic.

Why are we creating methods such as findByEmail(email)?

We should be creating function for findOne({email}) which will accept an object as it can be reused again by passing different arguments, Suppose I need to find a user by Id then I will need a another function which do not make sense to me.

No indentation in code

You can write the above code as below:

if(!validation) {
throw error;
}

Then continue coding

The above code looks good and also reduces the number of bolcks as we do not need else block now

Creating query for sort and search, There is too much of if and else, I do not think it was necessary, We may use switch.

And better to have helpers methods for these types of tasks that can handle it in more good manner

Why do we need to call list method of userRepository two times?

And why are we creating sortBy and even then passing limit and skip?

Why are we not taking a query object from controller to repository rather than passing arguments.

There are unnecessary calling of functions which can be reduced.

Why are we sending req object to update method????

We do not have to send the data that is being updated rather send the whole user after updation.

Why are we sure that the error will be of Email duplication?

Same comments as for above update method.

Why are we not using try catch in controller?

Why are we not taking these options from config??

Unnecessary else

throe this error please

Why are using Pascal Case over here for keys??

Pascal case for keys why??

Please use camel case

One line space before this line

Move this interface to respective file or folder

Why do we need this condition??

so that the user can update his own data

Use try catch in this please

No proper indentation.

Why eslint is not throwing errors?

Why are we passing req to this function rather we should be creating data and then sending the data to this function

Why lowercasing the name?

And why is the logic over here??
It should only contain the logic to updating document and making versions of the same.
THis function should not bother about the the data coming for updation

Why are we making query over here??

It should be passed by controller.

A line break

Aryan Singhal and others added 30 commits January 21, 2020 17:23

feat: Add VS-CODE.md

caeea38

Update VS-CODE.md

7be7cfe

Update VS-CODE.md

b082255

Added commands used

Merge pull request #1 from AryanSinghalGit/feature/39512

9c95b2d

feat: Add VS-CODE.md (#39512)

Delete VS-CODE.md

31d5837

Update VS-CODE.md

2384ec3

Update VS-CODE.md

20f4a92

change format

feat:Add .editorconfig

ca5658d

fix: conflicts

fd06a99

Merge pull request #4 from AryanSinghalGit/feature/39512

0617198

Docs: features and plugins of vscode (#39512)

feat : Add MERN-STACK.md

a9c6c33

feat : Add 12FACTOR-APP.md

45df94c

feat: Add CLIENT-SERVER.md

36f0c6c

feat: Add 12FACTOR-APP.md

97fa516

Merge pull request #5 from AryanSinghalGit/feature/39513

3ffca3c

feat: MERN Stack,12 factor app (#39513)

feat: Add Package extra

e4a708f

fix: Add package.json

32ee139

feat: Add package utils

1535f24

feat: Add package utils

a3187ba

feat : Add permissions.js

036fa32

fix: Add permissions.js

c090c19

fix: modified conflicts

16fa13b

"fix: Delete npm-debug.log"

ad25fb7

"feat: Delete npm-debug.log"

29d066c

feat: Add all

c25a914

Update validation.js

3230ef3

fix : validation.js

8eb6976

Merge pull request #6 from AryanSinghalGit/feature/39515

245211a

feat: Intro to Node.js & NPM (#39515)

Delete npm-debug.log

8cf6cb9

Delete npm-debug.log

d79daf3

nxvinay reviewed Mar 12, 2020

View reviewed changes

+                    return false;
+                  let data=permissions[moduleName];
+                  let tmp=false;
+                  if(data[permissionType]===undefined)

+              import { hasPermission, validateUser } from './utils/index';
+              import { Iuser } from './interface';
+              diamond(10);
+              equilateral(8);

+                      return false;
+                  const data = permissions[moduleName];
+                  let tmp: boolean = false;
+                  if (data[permissionType] === undefined)

+              import { userRepository } from '../../repositories/user';
+              import SystemResponse from '../../libs/SystemResponse';
+              import * as bcrypt from 'bcrypt';
+              class Controller {

+              import { userRepository } from '../../repositories/user';
+              import SystemResponse from '../../libs/SystemResponse';
+              import * as bcrypt from 'bcrypt';
+              class Controller {

+                  {
+                      str=str+" ";
+                  }
+                  for(let j=0;j<=i;j++)

+                  let str="";
+                  for(let k=0;k<n-i-1;k++)
+                  {
+                      str=str+" ";

		@@ -0,0 +1,3 @@
		import diamond from "./diamond.js";
		import equilateral from "./equilateral.js";

+                  if(email.match(regex))
+                  {
+                      return true;
+                  }

+                  let invalidEmails=[];
+                 user.forEach(function(value,index)
+                  {
+                      const {traineeEmail,reviewerEmail}=user[index];

+              }
+              export { Iuser };
+              interface Iauthority {
+                  all: string[];

+                      try {
+                          const hash = await bcrypt.hash(password, 10);
+                          email = email.toLowerCase();
+                          name = name.toLowerCase();

+                          const validity = await userRepository.findByEmail(email);
+                          if (!validity) {
+                          const userData = await userRepository.create(req.user._id, { name, address, email, dob, mob, hobbies, role, password: hash  });
+                          const message = 'Trainee added successfully';

+                              sortBy = { name: req.query.order};
+                          else
+                              sortBy = {updatedAt: req.query.order};
+                          if (req.query.search !== undefined) {

+                              dataList = await userRepository.list('trainee', req.query.skip, req.query.limit, sortBy, {name: { $regex: req.query.search.toLowerCase()}});
+                              const List = await userRepository.list('trainee', req.query.skip, req.query.limit, sortBy, {email: { $regex: req.query.search.toLowerCase()}});
+                              dataList = {...dataList, ...List };
+                          }

		@@ -0,0 +1,7 @@
		export interface IConfig {
		Port: string;

+                  update = async (req, res: Response) => {
+                      console.log('----------Update Trainee----------');
+                      try {
+                          const value = await userRepository.update(req, req.body.id, req.body.dataToUpdate);

+                          const value = await userRepository.update(req, req.body.id, req.body.dataToUpdate);
+                          if (value) {
+                              const message = 'Trainee Data successfully Updated';
+                              const data = req.body.dataToUpdate;

+                              SystemResponse.success(res, data, message);
+                          }
+                          else
+                              return SystemResponse.failure(res, 'User data is not Updated', 'Email id already exist');

+                      console.log('----------Delete Trainee----------');
+                      try {
+                          const value = await userRepository.delete(req, req.params.id);
+                          if (value) {

+                  }
+                  me = (req, res: Response) => {
+                      console.log('--------------me-------------');
+                      delete req.user.password;

+                              version: '1.0.0',
+                            },
+                          securityDefinitions: {
+                            Bearer: {

+                                  console.log(err);
+                              }
+                              else {
+                                  console.log(`Express app Successfully started on port : ${Port} `);

+                  Port : process.env.PORT,
+                  NODE_ENV : process.env.NODE_ENV,
+                  Key : process.env.SECRET_KEY,
+                  MongoURL: process.env.MONGO_URL,

@@ @@ -0,0 +1,6 @@ @@
+              import { Server } from './Server';
+              import  config from './config/configuration';
+              const server: Server = new Server(config);

+              import UserRepository from '../../repositories/user/UserRepository';
+              import IUserModel from '../../repositories/user/IUserModel';
+              interface IRequest extends Request {
+                  user: IUserModel;

feat: javascript-server by AryanSinghal · Pull Request #28 · AryanSinghal/javascript-server · GitHub

Repository navigation

feat: javascript-server - #28

feat: javascript-server#28AryanSinghal wants to merge 122 commits intomasterAryanSinghal/javascript-server:masterfrom developAryanSinghal/javascript-server:developCopy head branch name to clipboard

Conversation

AryanSinghal commented Mar 4, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

feat: javascript-server#28
AryanSinghal wants to merge 122 commits into
masterfrom
develop

+                      console.log(userData);
+                      req.user = userData;
+                      const role: string = userData.role;
+                      if (decodedUser._id === req.body.id && req.method === 'PUT')

+                  if (count === 0) {
+                      const { Password } = config;
+                      const hash = await bcrypt.hash(Password, 10);
+                      UserRepository.create(undefined, { ...user,  password: hash });

+                  }
+                  update = (req, id, updatedData) => {
+                     return super.update(req, id, updatedData);
+                   }

+                  }
+                  async delete(req, id) {
+                      const oldData: any = await this.versionModel.findOne({originalId: id , deletedAt: undefined}).exec();
+                      return this.versionModel.findByIdAndUpdate( oldData._id ,

+                      const oldData: any = await this.versionModel.findOne({originalId: id , deletedAt: undefined}).exec();
+                      const { name, address, email, dob, mob, hobbies, role, password} = oldData;
+                      if ( updatedData.name !== undefined)
+                          updatedData.name = updatedData.name.toLowerCase();

+              import { Router } from 'express';
+              import { traineeRouter, userRouter } from './Controllers';
+              const mainRouter: Router = Router();
+              mainRouter.use('/trainee', traineeRouter);