Merged
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
added 2 commits
May 26, 2020 16:17
rebase master
removed/commented out setting life_action_isUse and life_interruped to false directly within exitWith to trigger if() after the loop to return from it before the full jerrycan is given to inventory
BoGuu
requested changes
May 28, 2020
BoGuu
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Fine to just remove these comments all together!
Sorry, something went wrong.
removed commented out stuff as requested
ghost
requested a review
from BoGuu
May 28, 2020 13:43
Copy link
Copy Markdown
Member
|
Cheers! |
Sorry, something went wrong.
BoGuu
approved these changes
May 28, 2020
ghost
deleted the
master-fix-jerrycanrefuel
branch
May 28, 2020 16:07
that-edward
added a commit
to that-edward/Framework
that referenced
this pull request
Jun 7, 2020
Duplicates AsYetUntitled#686 on v5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #685
Changes proposed in this pull request:
commented out setting life_action_inUse and life_interrupted within exitWith inside the loop
I have tested my changes and corrected any errors found