Update fn_clearVehicleAmmo.sqf - #734
Open
FlorianGH wants to merge 2 commits into
Open
FlorianGH wants to merge 2 commits into
FlorianGH wants to merge 2 commits into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
moving the clearWeaponCargoGlobal _vehicle; to the top and using exitWith instead of then (or a switch) would actually be the best solution considering performance |
Sorry, something went wrong.
Like this?
DomT602
reviewed
Aug 22, 2020
Comment thread
Altis_Life.Altis/core/functions/fn_clearVehicleAmmo.sqf
| _vehicle removeMagazinesTurret ["2000Rnd_65x39_Belt_Tracer_Red",[1]]; | ||
| _vehicle removeMagazinesTurret ["2000Rnd_65x39_Belt_Tracer_Red",[2]]; | ||
| }; | ||
| private ["_vehicle","_veh"]; |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
We've managed to duplicate these 3 lines twice. It'd be best to remove the BIS_fnc_param and the private ARRAY and replace with params (obviously removing the duplication).
Sorry, something went wrong.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
At least 1 approving review is required to merge this pull request.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
Changed If to switch
I have tested my changes and corrected any errors found
It's just a little thing but it needs to be done.