| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
I worry a bit that we are adding so much passes to the pipeline (removing 4, adding 9, partly conditional) that optimization will become slower and slower while we keep doing this. I see that the additions reduce fixtures by about 330 lines, which is good in classical terms, and I'd lean towards merging, yet the relativistic concern remains that achieving the speed of light (zero lines of output) can only be achieved by supplying infinite energy (running passes forever) and is ultimately impossible because of diminishing returns unless becoming massless (optimizing no code at all). Or: Where do we draw the line? How much slowdown are we willing to accept for what gain? And how can we measure this as a function of time taken vs code optimized? |
Sorry, something went wrong.
|
Basically this attempts also speedup pipeline by doing some work earlier, before SSA and flattering. In my internal tests it's really little bit faster than previous scheme.
It will be great have some compiler benchmark with aggregate perf metrics and ideally with CI integration |
Sorry, something went wrong.
|
For npm run test:compiler -- --create (and via ts-node) roughly comparison: |
Sorry, something went wrong.
There was a problem hiding this comment.
In this case, LGTM :)
Sorry, something went wrong.
|
Since this touches a lot of fixtures, can you merge master into this PR and regenerate the fixtures? Mostly just in case, i.e. if an export not present before #1422 would now be present and somehow introduce a fixture-only conflict. |
Sorry, something went wrong.
|
Sure, done! But it seems it hasn't any changes |
Sorry, something went wrong.
|
Thanks! |
Sorry, something went wrong.
|
🎉 This PR is included in version 0.14.8 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Add more pre-SSA passes like simplify-locals-notee-nostructure and move redundant set elimination before SSA.