Allow functions to be called directly from element accesses - #2530
Closed
CountBleck wants to merge 2 commits into
Closed
Allow functions to be called directly from element accesses#2530CountBleck wants to merge 2 commits into
CountBleck wants to merge 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
MaxGraey
reviewed
Oct 8, 2022
Comment thread
tests/compiler/function-array.ts
Outdated
CountBleck
force-pushed
the
array-function-call
branch
from
6323b25 to
74b3925
Compare
October 8, 2022 07:34
dcodeIO
reviewed
Oct 8, 2022
Comment thread
src/compiler.ts
Outdated
CountBleck
force-pushed
the
array-function-call
branch
from
74b3925 to
80ac338
Compare
October 8, 2022 16:40
CountBleck
force-pushed
the
array-function-call
branch
from
80ac338 to
b55c739
Compare
November 7, 2022 23:12
This commit adds a case to compileCallExpression(), allowing element accesses to be used in function calls. This commit fixes AssemblyScript#2525.
CountBleck
force-pushed
the
array-function-call
branch
from
b55c739 to
61ba5de
Compare
November 9, 2022 05:23
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #2525