FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

implement the unix domain socket by silence-code · Pull Request #1688 · AsyncHttpClient/async-http-client · GitHub

/ async-http-client Public

implement the unix domain socket - #1688

Open
silence-code wants to merge 3 commits into
AsyncHttpClient:mainfrom
silence-code:uds
ConversationCommits (3)ChecksFiles changed
Open

implement the unix domain socket#1688
silence-code wants to merge 3 commits into
AsyncHttpClient:mainfrom
silence-code:uds

Conversation

silence-code commented Jan 6, 2020

Copy link
Copy Markdown

usage can see example.CompletableFutures

slandelle suggested changes Jan 7, 2020
View reviewed changes

slandelle left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The problem with this PR is that is completely break the existing API because of the InetAddress to SocketAddress change.
Sadly, I'm not willing to break everything now for the sole sake of supporting domain sockets. Maybe in a future major release.

Comment thread client/src/main/java/org/asynchttpclient/RequestBuilderBase.java Outdated
Comment thread client/src/main/java/org/asynchttpclient/netty/channel/ChannelManager.java Outdated
Comment thread client/src/main/java/org/asynchttpclient/netty/channel/ChannelManager.java Outdated
Comment thread client/src/main/java/org/asynchttpclient/netty/channel/ChannelManager.java Outdated
Comment thread client/src/main/java/org/asynchttpclient/netty/channel/ChannelManager.java Outdated
Comment thread client/src/main/java/org/asynchttpclient/netty/channel/EpollDomainTransportFactory.java Outdated
Comment thread client/src/main/java/org/asynchttpclient/netty/channel/KQueueDomainTransportFactory.java Outdated
Comment thread client/src/main/java/org/asynchttpclient/netty/request/NettyRequestSender.java
abort(null, future, getCause(cause));
}
});
}else {

slandelle Jan 7, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

code not formatted

silence-code Jan 18, 2020

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

My idea does not meet the formatting rules, please help format

silence-code commented Jan 16, 2020

Copy link
Copy Markdown
Author

Thanks for your code review, I will take the time to solve the problem of breaking these existing APIs.

silence-code commented Jan 18, 2020

Copy link
Copy Markdown
Author

I have reduced the breaking of the original API

silence-code commented Feb 7, 2020

Copy link
Copy Markdown
Author

Can I ask which version can incorporate this function?

slandelle force-pushed the master branch 5 times, most recently from 6ea11f4 to f8fab66 Compare February 7, 2020 12:25

silence-coding commented Sep 2, 2020

Copy link
Copy Markdown

When will this feature be supported?

vy commented Jan 29, 2026

Copy link
Copy Markdown

Fixes #1670.

hyperxpro commented Jan 29, 2026

Copy link
Copy Markdown
Member

@vy PR needs to be rebased with 3.x branch; are you willing to pick it up? Or I can do as well.

vy commented Jan 29, 2026

Copy link
Copy Markdown

@hyperxpro, I was just trying to get the GitHub references right.
I will kindly pass your gratuitous offer of picking up this task.

hyperxpro force-pushed the main branch 2 times, most recently from c6640bd to 83e552e Compare August 9, 2026 22:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
slandelle slandelle requested changes
Reviewers whose approvals may not affect merge requirements

At least 0 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL