| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
There was a problem hiding this comment.
Not in this PR's diff, so leaving it here: this change makes HTTP/2 after CONNECT work, which makes the workaround in client/src/test/java/org/asynchttpclient/proxy/HttpsProxyTestcontainersIntegrationTest.java stale and its comment misleading. Could you remove .setHttp2Enabled(false) and the // HTTP/2 ALPN upgrade after proxy CONNECT tunnel is not yet supported comment in both testHttpProxyToHttpsTarget (lines 149-150) and testHttpsProxyToHttpsTarget (lines 172-173)? That lets those external tests exercise the new HTTP/2-through-proxy path instead of forcing HTTP/1.1, and the comment stops claiming something that is no longer true.
Sorry, something went wrong.
|
Done - removed .setHttp2Enabled(false) and the stale comment from both proxy-to-HTTPS Testcontainers tests. They now use the default HTTP/2-enabled configuration. |
Sorry, something went wrong.
|
Hi @hyperxpro, just a gentle reminder when you get a chance. I've addressed the review comments and would appreciate a re-review. Thanks! |
Sorry, something went wrong.
|
Thanks a lot! |
Sorry, something went wrong.
|
Hey @hyperxpro - thanks again for reviewing and merging this! Could you share how the release process usually works for this project? Will this change be included in the next release, and is there a rough timeline for it? |
Sorry, something went wrong.
|
There is no fixed release cycle - but I hope to cut a release next week, |
Sorry, something went wrong.
|
Hey @hyperxpro - just wanted to follow up on the release. Would there be one this week? |
Sorry, something went wrong.
It will be Wednesday |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Motivation
When an HTTPS request uses an HTTP proxy, AHC establishes a CONNECT tunnel and then performs TLS with the target. If ALPN selects h2, the tunnel path currently leaves the HTTP/1.1 codec in place. The target then receives HTTP/1.1 bytes on a connection that negotiated HTTP/2 and closes it.
Modification
Result
HTTPS requests through HTTP and HTTPS CONNECT proxies now send HTTP/2 frames when the target negotiates h2. The regression tests verify successful HTTP/2 responses and reuse of a single physical target connection.
Testing
Fixes #2241