Avoid unused promise allocation in address resolution - #2259
Merged
hyperxpro merged 1 commit intoJul 23, 2026
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
pavel-ptashyts
marked this pull request as ready for review
July 19, 2026 15:50
Move promise creation in NettyRequestSender.resolveAddresses into the explicit-address bypass path. Hostname and proxy resolution paths no longer allocate a succeeded promise they do not use, while explicit address requests keep the same completed Future behavior. Codex on behalf of Pavel Ptashyts Co-Authored-By: Codex <codex@openai.com>
pavel-ptashyts
force-pushed
the
perf/resolve-addresses-promise
branch
from
d4b6d59 to
bd64aab
Compare
July 20, 2026 08:50
hyperxpro
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
Most requests resolve by hostname and do not use the local Promise created at the start of resolveAddresses. Deferring the allocation keeps the explicit-address behavior unchanged while reducing per-request allocation on the common path.
Validation
Attribution
Codex on behalf of Pavel Ptashyts