Avoid rebuilding clean query strings - #2265
Merged
hyperxpro merged 6 commits intoJul 24, 2026
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
pavel-ptashyts
force-pushed
the
perf/lazy-query-encoding
branch
from
2da5f56 to
d2086e8
Compare
July 20, 2026 08:50
Add a lazy query-string encoder that mirrors the existing path encoder fast path. When a query contains only pass-through characters, UriEncoder now reuses the original String instead of allocating a pooled StringBuilder and an equal replacement String. The append-based path is unchanged for URLs with additional query params. Existing escaping behavior is preserved for queries that need percent-encoding. Codex on behalf of Pavel Ptashyts Co-Authored-By: Codex <codex@openai.com>
The lazy query encoder is an implementation detail used only by UriEncoder and same-package tests. Publishing it would expand the supported API without a caller-facing requirement. Keep the allocation optimization while limiting the helper to its package. Codex on behalf of Pavel Ptashyts Co-Authored-By: Codex <codex@openai.com>
pavel-ptashyts
force-pushed
the
perf/lazy-query-encoding
branch
from
1e41fb2 to
b4badf5
Compare
July 20, 2026 15:08
hyperxpro
reviewed
Jul 24, 2026
hyperxpro
requested changes
Jul 24, 2026
Comment thread
client/src/test/java/org/asynchttpclient/util/Utf8UrlEncoderTest.java
Outdated
Comment thread
client/src/test/java/org/asynchttpclient/util/Utf8UrlEncoderTest.java
Outdated
Comment thread
client/src/test/java/org/asynchttpclient/util/Utf8UrlEncoderTest.java
Outdated
Co-authored-by: Aayush Atharva <24762260+hyperxpro@users.noreply.github.com>
hyperxpro
requested changes
Jul 24, 2026
Comment thread
client/src/test/java/org/asynchttpclient/util/Utf8UrlEncoderTest.java
Outdated
hyperxpro
requested changes
Jul 24, 2026
Comment thread
client/src/test/java/org/asynchttpclient/util/Utf8UrlEncoderTest.java
Outdated
hyperxpro
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rationale
UriEncoder already reuses the original Uri when encoding produces equal path and query values, but the existing query path still allocated a StringBuilder and replacement String for clean queries. The new helper mirrors the path encoder's lazy behavior and avoids that temporary allocation in the common already-encoded REST query case.
Validation
Attribution
Codex on behalf of Pavel Ptashyts