Intern common Train-Case header names - #2266
Merged
hyperxpro merged 4 commits intoJul 23, 2026
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Extend NettyRequestFactory's known header-name table with prebuilt Train-Case AsciiString instances for the common headers already covered by lowercase Netty constants. This lets caller-supplied names such as Content-Type and Authorization take the HttpHeadersEncoder bulk-copy path while preserving on-wire casing. Odd casing and custom header names still miss the table and pass through unchanged. Update focused interning tests for Train-Case interning and odd-casing passthrough. Codex on behalf of Pavel Ptashyts Co-Authored-By: Codex <codex@openai.com>
pavel-ptashyts
force-pushed
the
perf/train-case-header-interning
branch
from
d64a80f to
a142238
Compare
July 20, 2026 08:50
hyperxpro
requested changes
Jul 23, 2026
Comment thread
client/src/main/java/org/asynchttpclient/netty/request/NettyRequestFactory.java
Outdated
Comment thread
client/src/main/java/org/asynchttpclient/netty/request/NettyRequestFactory.java
Outdated
hyperxpro
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rationale
NettyRequestFactory already interns known lowercase header names so HttpHeadersEncoder can bulk-copy AsciiString bytes on the event loop. Real request code often supplies names such as Content-Type and Authorization in Train-Case, which previously missed the table and fell back to per-character encoding. Adding same-spelling AsciiString entries preserves wire casing while putting those common names on the same fast path.
Validation
Attribution
Codex on behalf of Pavel Ptashyts