WatchOS Support - #26
Merged
gre4ixin merged 18 commits intoNov 29, 2022
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…n appears to match the behaviour of the requestLocation() function. - Additionally the change of behaviour doesn't appear to have anything to do with watchOS support.
gre4ixin
self-requested a review
November 19, 2022 21:43
…use permission Without this change, any attempt to request an always permission when we already have a when-in-use permission will be ignored, and the when-in-use permission will be returned.
Modified initialisers to use default parameters.
Modified initialisers to use default parameters.
…pdates. Added tests for new code.
… there maybe a cleaner way of doing this.
gre4ixin
approved these changes
Nov 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I started with ElyesDer's WatchOS commit 575745a and updated it to the latest base repository code. I've tested it on a real Series 5 Watch during a 25 minute run and it appears to work fine.
close #23