Adding unit tests for net.authorize.sample.Sha512.ComputeTransHashS512 - #91
Open
EdgarScott wants to merge 1 commit into
Open
EdgarScott wants to merge 1 commit into
EdgarScott wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
EdgarScott
force-pushed
the
add-diffblue-tests-30-08-2019
branch
from
3dc4b50 to
536e559
Compare
September 17, 2019 09:09
…2.java These tests were written using Diffblue Cover
EdgarScott
force-pushed
the
add-diffblue-tests-30-08-2019
branch
from
536e559 to
aad48ef
Compare
September 17, 2019 09:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've analysed your codebase and noticed that net.authorize.sample.Sha512.ComputeTransHashSHA512 is not fully tested.
I've written some tests for this class with the help of Diffblue Cover.
Hopefully, these tests will help you detect any regressions caused by future code changes. If you would find it useful to have additional tests written for other classes, I would be more than happy to look further.