Return error response based on caught exception from postData - #164
Open
mkienenb wants to merge 1 commit into
Open
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm resubmitting this pull request.
The original PR #89 was cancelled without fixing the general issue (caught exceptions are logged but return null responses) because the symptom was fixed (xml parsing exception).
Summary of the general issue:
When an exception occurs during an ANetApiResponse.get(), the exception is sent to the logger, and the method returns null instead of a valid ANetApiResponse. The API eventually returns a null response to the caller with no information about what occurred.
This PR returns an error ANetApiResponse containing the information from the exception instead of null if an exception is caught, which allows the caller to do something with the exception.
[Note: the updated CONTRIBUTING.md guidelines refer to the future branch, which no longer exists.]