Patch request for phone fix - #48
Open
Rickard (rickardliljeberg) wants to merge 1 commit into
Open
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
If user already had phone number of a type, say "work" and then got another number added of type "mobile" the code would crash during the patch request.
Bosco (boscoMW)
requested review from
Bosco (boscoMW) and
Marcus Carvalho (marcusca10)
January 20, 2022 13:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we first add a "work" phone number all worked well.
Now howver we add a "mobile" number with a patch request. It would then see that we had any numbers at all since before, then it would try to look up a number of type "mobile" (however only number of type "work" exists) so it would return null.
A few lines further down it would assume phonNumber is a valid object which it's not.