FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Update to .NET 8 by Sefriol · Pull Request #99 · AzureAD/SCIMReferenceCode · GitHub

Update to .NET 8 - #99

Open
Joakim (Sefriol) wants to merge 10 commits into
AzureAD:masterfrom
Sefriol:master
Open

Update to .NET 8#99
Joakim (Sefriol) wants to merge 10 commits into
AzureAD:masterfrom
Sefriol:master

Conversation

Joakim (Sefriol) commented May 20, 2024
edited
Loading

Copy link
Copy Markdown
  • Update other dependancies
  • Convert Postman Collection into Playwright API tests
  • Squash commits
  • Remove Newtonsoft?

Joakim (Sefriol) changed the title Update to DotNet 8 Update to .NET 8 May 20, 2024
Joakim (Sefriol) force-pushed the master branch 8 times, most recently from b2df41f to 597d804 Compare May 24, 2024 15:58
Joakim (Sefriol) marked this pull request as ready for review May 24, 2024 16:15

Copy link
Copy Markdown
Author

Removal on Newtonsoft might be possible, but requires so much rewrite that it needs its own PR.

While Postman collection was okey for testing, it was rather slow to run and requires a license for those who are most likely candidates to use software like this. I created a Playwright tests that mimic the test cases of the postman collection and improve them a little bit.

I also removed a bunch of files which were not used, but some might be in some other context (like profile pictures and photos?). I am not sure if DataContract classes were auto-generated using some tool, but feel free to give guidance on how to make this PR work.

Bosco (@boscoMW) Marcus Carvalho (@marcusca10) Are you currently overseering this repo?

Copy link
Copy Markdown

you have a bug in
public static class RequestExtensions
public static Uri GetBaseResourceIdentifier(this HttpContext context)

line string resourceIdentifier = new Uri(context.Request.Path.Value).AbsoluteUri;
throw exception, because

context.Request.Path.Value = /scim/Users and not https://{host[:{port}/scim/Users

you can not build an Uri from incomplete string

Copy link
Copy Markdown
Author

you have a bug in public static class RequestExtensions public static Uri GetBaseResourceIdentifier(this HttpContext context)

line string resourceIdentifier = new Uri(context.Request.Path.Value).AbsoluteUri; throw exception, because

context.Request.Path.Value = /scim/Users and not https://{host[:{port}/scim/Users

you can not build an Uri from incomplete string

Good catch. Fixed.

Copy link
Copy Markdown

Whats the status of this PR?

Copy link
Copy Markdown

also interesting

Copy link
Copy Markdown
Author

Repository probably needs a complete rewrite. It has a lot of files which are almost impossible to figure out what they are for.

And it seems like there is no current maintainers for this repository, so this PR will most likely go nowhere.

AmitavaHazra left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

ok

AmitavaHazra commented Mar 17, 2025
edited
Loading

Copy link
Copy Markdown

Joakim (@Sefriol) , Can you please help to merge your updated version of this sample with .net v8.0 into AzureAD:master branch.

Copy link
Copy Markdown
Author

I would need input from the repository maintainers, but there seems to be none.

Copy link
Copy Markdown

Joakim (@Sefriol) Yes, can I somehow get this updated repository link where you have complete updated versioning of this sample using .net8.0

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants


Back | FazBrowse Home | New Git URL