| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
There was a problem hiding this comment.
Note
Copilot was unable to run its full agentic suite in this review.
Updates the Android unit test harness and related dependencies to newer Android tooling (API 35 / newer NDK), improves Android-native logging, and adds compatibility for different V8 Inspector connect() signatures.
Changes:
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file| File | Description |
|---|---|
| Tests/UnitTests/Android/app/src/main/cpp/JNI.cpp | Routes debug trace output to Android Logcat instead of stdout. |
| Tests/UnitTests/Android/app/build.gradle | Updates SDK/NDK configuration and refines ABI filter behavior. |
| README.md | Updates Android setup instructions to match new SDK/NDK/API level expectations. |
| Core/Node-API/package-jsc.json | Bumps jsc-android dependency version. |
| Core/AppRuntime/V8Inspector/Source/V8InspectorAgent.cpp | Adds V8 version-based connect() handling and adjusts string buffer creation. |
| .github/workflows/build-android.yml | Moves CI emulator image to API level 35. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Summary
This PR now contains only the Android/runtime-host work that is still missing from main after rebasing onto 8cd1429:
The Android setup instructions now name the SDK and NDK versions required by this test configuration.
Work already superseded or removed
Validation
Scope
This is Android API/toolchain and runtime-host preparation; it is not by itself complete BabylonNative Android XR support. OpenXR loader/manifest wiring, lifecycle and input integration, arm64 Android CI/ELF auditing, and validation on Galaxy XR/XREAL hardware remain separate follow-up work (principally BabylonNative#1766).