Drop redundant Linux compiler env from build-linux.yml - #205
Open
bghgary wants to merge 1 commit into
Open
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
The job set CC/CXX env alongside the authoritative -D CMAKE_C_COMPILER / -D CMAKE_CXX_COMPILER configure flags, which already select the compiler; the env block was redundant. No behavior change (verified on the parallel UrlLib cleanup: both the gcc and clang Linux jobs stay green with the env removed). The Run Tests step's env (TSAN_OPTIONS / JSC_useConcurrentGC) is unaffected. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Pull request overview
This PR simplifies the reusable Linux build workflow by removing a redundant job-level CC/CXX environment override, relying solely on the existing CMake -D CMAKE_C_COMPILER / -D CMAKE_CXX_COMPILER configuration inputs to select the toolchain.
Changes:
- Removed job-level env: CC/CXX from the Linux build job.
- Kept compiler selection driven by CMake configure flags (CMAKE_C_COMPILER / CMAKE_CXX_COMPILER).
- Left the test-step-specific environment (TSAN_OPTIONS, JSC_useConcurrentGC) unchanged.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
build-linux.yml set job-level CC/CXX env alongside the -D CMAKE_C_COMPILER / -D CMAKE_CXX_COMPILER configure flags. The -D flags already select the compiler for both the gcc and clang matrix legs, so the env block was redundant.
No behavior change: on the parallel UrlLib CI cleanup both the gcc and clang Linux jobs stayed green with the env removed. The Run Tests step's env (TSAN_OPTIONS / JSC_useConcurrentGC) is untouched.
Part of a small cross-repo consistency pass — UrlLib landed the same cleanup. BabylonNative was checked and intentionally left alone: its build-linux.yml env is load-bearing there (its configure passes no -D compiler flags).
[Created by Copilot on behalf of @bghgary]