Add timeout parameter for downloading - #482
Open
an920107 wants to merge 2 commits into
Open
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
an920107
marked this pull request as ready for review
February 19, 2025 04:04
2 tasks
Copy link
Copy Markdown
|
@martijn00 can we have this reviewed? Thans for the time effort :D |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)
This PR is to resolve #141, supporting pass timeout for downloading.
⤵️ What is the current behavior?
There is no way to set timeout.
🆕 What is the new behavior (if this is a feature change)?
A timeout duration can be set, and the http request will be timeouted after the duration (a TimeoutException will be thrown). If timeout is not set, all behaviors are same with the original.
💥 Does this PR introduce a breaking change?
N/A
🐛 Recommendations for testing
📝 Links to relevant issues/docs
Issue #141.
🤔 Checklist before submitting