Fix red CI on main: format, analyze and Android example build - #1045
Merged
mvanbeusekom merged 6 commits intoSep 23, 2026
Merged
mvanbeusekom merged 6 commits into
mvanbeusekom merged 6 commits into
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Pure `dart format .` output from Dart 3.13.2 (Flutter 3.47.2 stable), with no hand edits. The CI Format job runs `dart format --set-exit-if-changed .` on this package and has failed since the formatter moved to the tall style underneath unpinned workflows. Review the rest of this PR commit by commit; this one only changes whitespace and line breaks. Co-Authored-By: Claude <noreply@anthropic.com>
Fixes the prefer_initializing_formals info that fails the CI Analyze job and costs 10 pub points. `required this._scale` is a private named parameter, so callers still pass `scale:` and the public API is unchanged. Co-Authored-By: Claude <noreply@anthropic.com>
The checklist still asked for a rebase onto develop and linked CONTRIBUTING.md at the repo root on develop. That file moved to cached_network_image/CONTRIBUTING.md in the folder restructure, so the link was broken as well as pointing at the retired branch. Co-Authored-By: Claude <noreply@anthropic.com>
Current stable Flutter no longer builds AGP 7.3.0 with Kotlin 1.7.10
("Language version 1.4 is no longer supported"), which fails the CI
Build Android App job. Copies flutter_cache_manager's example setup,
which is green in CI: AGP 9.0.1, Kotlin 2.3.20, Gradle 9.1.0, Java 17,
and flutter.versionCode/versionName in place of reading local.properties.
`flutter build apk --release` succeeds locally on Flutter 3.47.2.
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
mvanbeusekom
approved these changes
Sep 23, 2026
…ain-android-build-format-and
mvanbeusekom
deleted the
rick/fpl-33-cached_network_image-ci-red-on-main-android-build-format-and
branch
September 23, 2026 06:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)
Bug fix (CI). app_facing_package has failed on every run since at least 28 August, and three of the nine required checks are red on main (run 35771535478). Nothing can merge the normal way until they pass.
⤵️ What is the current behavior?
🆕 What is the new behavior (if this is a feature change)?
💥 Does this PR introduce a breaking change?
No
🐛 Recommendations for testing
Please review commit by commit. The first commit is pure dart format . output with no hand edits, and accounts for about 960 of the roughly 1,000 changed lines. AGENTS.md asks for a reformat to be its own PR. It rides along as its own commit here because the Format check needs it and neither half can go green without the other. Please merge with a merge commit, not a squash, so the reformat stays separate in history.
Ran locally on Flutter 3.47.2 stable: dart format --set-exit-if-changed ., flutter analyze (no issues), flutter test (37 passed), and flutter build apk --release in the example. On CI, check that all nine app_facing_package jobs are green. The sibling workflows (platform_interface, platform_web, web) are not triggered by this PR. They follow separately.
📝 Links to relevant issues/docs
Failing run on main: https://github.com/Baseflow/flutter_cached_network_image/actions/runs/35771535478
🤔 Checklist before submitting
🤖 Generated with Claude Code