FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Expose `scale` of CachedNetworkImageProvider on CachedNetworkImage by amake · Pull Request #576 · Baseflow/flutter_cached_network_image · GitHub

  1. Baseflow
  2. flutter_cached_network_image

Repository navigation

Expose scale of CachedNetworkImageProvider on CachedNetworkImage - #576

Merged
martijn00 merged 1 commit into
Baseflow:developfrom
amake:feature/expose-scale
Jul 31, 2024
ConversationCommits (1)ChecksFiles changed
Merged

Expose scale of CachedNetworkImageProvider on CachedNetworkImage#576
martijn00 merged 1 commit into
Baseflow:developfrom
amake:feature/expose-scale

Conversation

amake commented Mar 21, 2021

Copy link
Copy Markdown
Contributor

✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)

This PR exposes the scale argument of CachedNetworkImageProvider in the CachedNetworkImage constructor.

⤵️ What is the current behavior?

Currently you cannot set the scale used by the implicitly instantiated CachedNetworkImageProvider, so if you need to set the image scale then you have to use something like Image(image: CachedNetworkImageProvider(url)) so you can't take advantage of the various nice features of CachedNetworkImage.

🆕 What is the new behavior (if this is a feature change)?

Now you can pass the scale argument.

💥 Does this PR introduce a breaking change?

No. The argument has the same default as CachedNetworkImageProvider so the behavior is unchanged if not supplied.

🐛 Recommendations for testing

Try supplying different values of scale to CachedNetworkImage and ensure they take effect.

📝 Links to relevant issues/docs

#572

🤔 Checklist before submitting

  • All projects build
  • Follows style guide lines (code style guide)
  • Relevant documentation was updated
  • Rebased onto current develop

amake force-pushed the feature/expose-scale branch from 8954fc5 to e2d8ee6 Compare March 30, 2021 07:27

amake commented Mar 30, 2021

Copy link
Copy Markdown
Contributor Author

It looks like the CI failure is not related to my changes:

Found "Xcode 11.1, Build version 11A1027". Xcode 12.0.1 or greater is required to develop for iOS.

amake force-pushed the feature/expose-scale branch from e2d8ee6 to 636db53 Compare September 3, 2021 11:49

amake commented Sep 3, 2021

Copy link
Copy Markdown
Contributor Author

I've resolved the conflicts.

GZaccaroni commented Sep 26, 2021

Copy link
Copy Markdown

Please merge this PR, really useful!

bounty1342 commented Nov 11, 2021

Copy link
Copy Markdown

One use case could be to use it with a seamless image pattern and repeat option, in order to scale the pattern.
https://www.designer.io/en/tutorials/graphic-design/how-to-design-seamless-pattern/

alexislg2 commented Dec 6, 2021

Copy link
Copy Markdown

Any plan to merge this?
I don't understand how are we supposed to deal with images too small if we want them to be displayed full screen.

amake force-pushed the feature/expose-scale branch from 636db53 to b44c05b Compare September 25, 2023 22:30

amake commented Sep 25, 2023

Copy link
Copy Markdown
Contributor Author

I've resolved the conflicts again.

amake commented Oct 12, 2023

Copy link
Copy Markdown
Contributor Author

This test failure appears to be spurious.

alexislg2 commented Dec 13, 2023

Copy link
Copy Markdown

If you don't plan to merge this PR, could you at least tell why and close it?

martijn00 force-pushed the feature/expose-scale branch 2 times, most recently from 21fd20b to 2e82902 Compare July 31, 2024 16:34
martijn00 force-pushed the feature/expose-scale branch from 2e82902 to 57854a6 Compare July 31, 2024 17:21
martijn00 merged commit 94d6ab2 into Baseflow:develop Jul 31, 2024
amake added a commit to amake/orgro that referenced this pull request Aug 17, 2024
Use CachedNetworkImage now that scale is specifiable
13c94d2 
Baseflow/flutter_cached_network_image#576
abaj8494 pushed a commit to abaj8494/orgro that referenced this pull request Feb 1, 2026
Use CachedNetworkImage now that scale is specifiable
5edda06 
Baseflow/flutter_cached_network_image#576
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
martijn00 martijn00 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL