FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Replace custom MultiImageStreamCompleter with flutter/foundation/MultiFrameImageStreamCompleter by lwj1994 · Pull Request #949 · Baseflow/flutter_cached_network_image · GitHub

Replace custom MultiImageStreamCompleter with flutter/foundation/MultiFrameImageStreamCompleter - #949

Open
lwj1994 wants to merge 1 commit into
Baseflow:developfrom
lwj1994:develop
Open

Replace custom MultiImageStreamCompleter with flutter/foundation/MultiFrameImageStreamCompleter#949
lwj1994 wants to merge 1 commit into
Baseflow:developfrom
lwj1994:develop

Conversation

lwj1994 commented May 29, 2024
edited
Loading

Copy link
Copy Markdown

on 3.19,it will lead some ios crash

fix flutter/flutter#148927

There is no need to use Stram, as it will only fire once.

when result is FileInfo, it means download success.

      await for (final result in stream) {
        if (result is DownloadProgress) {
          chunkEvents.add(
            ImageChunkEvent(
              cumulativeBytesLoaded: result.downloaded,
              expectedTotalBytes: result.totalSize,
            ),
          );
        }
        if (result is FileInfo) {
          final file = result.file;
          final bytes = await file.readAsBytes();
          final decoded = await decode(bytes);
          yield decoded;
        }
      }

lwj1994 force-pushed the develop branch 2 times, most recently from 7fbf8ef to 3de8c60 Compare May 30, 2024 08:03
lwj1994 changed the title Update MultiFrameImageStreamCompleter (fix decode image crash) User flutter MultiFrameImageStreamCompleter May 30, 2024
martijn00 force-pushed the develop branch 2 times, most recently from 0d48bec to 8d8ff6f Compare July 31, 2024 17:23

Copy link
Copy Markdown
Contributor

@lwj1994 Can you provide more info on this and rebase and fix issues?

lwj1994 commented Aug 1, 2024
edited
Loading

Copy link
Copy Markdown
Author

Can you provide more info on this and rebase and fix issues?

@martijn00 hi.
The basic information is as described above. I received feedback from online users about the app crashing. The app crashes after scrolling for a while in a dual-column image list. This branch has been live for a month now and has been stable with no crash until now.

lwj1994 changed the title User flutter MultiFrameImageStreamCompleter Use flutter MultiFrameImageStreamCompleter Aug 1, 2024
lwj1994 changed the title Use flutter MultiFrameImageStreamCompleter Remove ImageStreamCompleter Aug 22, 2024
lwj1994 changed the title Remove ImageStreamCompleter Remove custom ImageStreamCompleter Aug 22, 2024
lwj1994 changed the title Remove custom ImageStreamCompleter Replace custom ImageStreamCompleter Aug 22, 2024
lwj1994 changed the title Replace custom ImageStreamCompleter Replace custom ImageStreamCompleter with flutter.framework. ImageCompleter Aug 22, 2024
lwj1994 changed the title Replace custom ImageStreamCompleter with flutter.framework. ImageCompleter Replace customful MultiImageStreamCompleter with flutter/foundation/MultiFrameImageStreamCompleter Aug 22, 2024
lwj1994 changed the title Replace customful MultiImageStreamCompleter with flutter/foundation/MultiFrameImageStreamCompleter Replace custom MultiImageStreamCompleter with flutter/foundation/MultiFrameImageStreamCompleter Aug 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

crashed on ios old device (low memory?)

2 participants


Back | FazBrowse Home | New Git URL