Timeout refactor - #1
Open
CoderMiguel wants to merge 5 commits into
Open
CoderMiguel wants to merge 5 commits into
CoderMiguel wants to merge 5 commits into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
The Heroku-24 stack does not include `bc` and bash cannot do non-integer math. Use `awk` to convert the timeout & interval to milliseconds so we can use build-in bash math operators.
CoderMiguel
commented
Aug 8, 2025
Comment thread
bin/heroku-tailscale-start.sh
| (tailscaled -verbose ${TAILSCALED_VERBOSE:--1} --tun=userspace-networking --socks5-server=localhost:1055 > /dev/null 2>&1 &) | ||
| (tailscaled -verbose ${TAILSCALED_VERBOSE:--1} --tun=userspace-networking --socks5-server=localhost:1055 > /dev/null 2>&1 &) | ||
| tailscale up \ | ||
| --authkey="${TAILSCALE_AUTH_KEY}?preauthorized=true&ephemeral=true" \ |
Copy link
Copy Markdown
Author
There was a problem hiding this comment.
the query params here are causing a:
backend error: invalid key: unable to validate API keyI believe that these attributes are handled in the API Key that is generated in the Tailscale admin UI
Sorry, something went wrong.
Comment thread
bin/heroku-tailscale-start.sh
Comment on lines
-48
to
+52
| --timeout=15s \ | ||
| ${TAILSCALE_ADDITIONAL_ARGS:---timeout=15s} | ||
| ${TAILSCALE_ADDITIONAL_ARGS:---accept-routes --timeout=15s} |
Copy link
Copy Markdown
Author
There was a problem hiding this comment.
This is a refactor to make sure that the --timeout flag value that may be in $TAILSCALE_ADDITIONAL_ARGS is not overridden by the preexisting --timeout=15s \ and leaves --accept-routes as a default but an option that could be removed as well without making a new $ENV_VAR
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CoderMiguel#1