[Zellic Audit] Fix Pushing Data - #14
Merged
RobinLinus merged 3 commits intoOct 10, 2025
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
sander2
approved these changes
Aug 14, 2025
sander2
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM. Just one note: this does make pushing [x] where 1 <= x <= 16 less efficient - one byte can be saved by doing the optimization that push_int was doing
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
While applying @sander2's suggestion, I also realized that pushing [x] satisfying 128 < x < 256 with push_slice resulted in an invalid instruction, so I've split the single element case into 3 parts. This should now both be optimized and functioning properly. |
Sorry, something went wrong.
sander2
reviewed
Aug 18, 2025
Comment thread
src/builder.rs
Outdated
sander2
approved these changes
Aug 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug that causes an unexpected behaviour while pushing Vec<u8> or bitcoin::Witness to the stack. If a single length Vec<u8> was pushed to the stack [x], satisfying 128 <= x < 256, it was being interpreted as pushing [x, 0], causing both numbers pushed through Witness and single length vectors to act unexpectedly.