bugfix: split fan/speed slider callbacks to fix gcode dispatch collision - #212
bugfix: split fan/speed slider callbacks to fix gcode dispatch collision#212HugoCLSC merged 5 commits into
Conversation
Sorry, something went wrong.
HugoCLSC
left a comment
There was a problem hiding this comment.
This needs more work.
There is no reason whatsoever where the slider should only emit a gcode for fan speed changes on objects that are [fan_generic]. Normal fans [fan] should have their speed changed using the slider as well.
So the slider needs to emit the appropriate gcode according to the fan object declaration.
Second thing, the gcode command M220 has nothing to do with fan speeds, that command sets the feedrate percentage . The appropriate command that i believe you were looking for is M106 SX, where X is an integer between [0-255].
Additionally, what happened with the ControlTab.py file, because the entire file is diff. I suggest just having just the actual changes.
Sorry, something went wrong.
…ic]; drop normalize dependency and ruff fixes
Description
Motivation
When a fan_generic was named "speed", both controlTab and tunePage would dispatch conflicting gcodes (SET_FAN_SPEED and M220) on the same slider event. Additionally, [fan] objects require M106 not SET_FAN_SPEED, and the previous code used M220 (feedrate override) on the fan path entirely. Splitting the callbacks and centralising gcode generation eliminates the collision and ensures the correct command is always sent regardless of fan type or name